Meine Open-Source-Aktivitäten

Abbonieren

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

I don't know any good API which does this kind of job.

I think the first approach with just one wildcard is sufficient. This makes it probably easier for you.

schrieveslaach accepted merge request !10: Filter EngineDescription if TypeCa...

Replaced simple java class#getAnnotation with AnnotationUtils to support annotation inheritance.

Filtering EngineDescription if TypeCapability annotation is not present to avoid NullPointerException.

Fixes #32

schrieveslaach closed issue #32: NPE if TypeCapability is null at schrievesla...

If the TypeCapability is null, the IsolatedToolsTestMojo causes a NullpointerException. e.g. the IxaPosTagger does not provide any TypeCapability information and if you add the dependency you cant run any analysis.

schrieveslaach pushed to project branch master at schrieveslaach / NLPf

schrieveslaach (3d6a700b) at 09 Nov 07:33

Merge branch 'feature/fix-empty-type-capability' into 'master'

... and 1 more commit

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

According to my comment below/above this configuration example changes:

<configuration>
 <excludedTrainers>
 <excludedTrainer>de.tudarmstadt.ukp.dkpro.core.opennlp.OpenNlpSentenceTrainer</excludedTrainers>
 </excludedTrainers>
</configuration>

Additionally, an asterisk would be nice too:

<configuration>
 <excludedTrainers>
 <excludedTrainer>de.tudarmstadt.ukp.dkpro.core.opennlp.*</excludedTrainers>
 </excludedTrainers>
</configuration>

Or two asterisks:

<configuration>
 <excludedTrainers>
 <excludedTrainer>de.tudarmstadt.ukp.dkpro.core.**</excludedTrainers>
 </excludedTrainers>
</configuration>

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

I like <excludes>.

However, I noticed that the new feature you're implementing is not exactly what you would expect as a user of NLPf. I would expect that the <excludes> take care that you will not generate any NLP model. However, your filtering excludes only the testing. It also filters the engine factories which lead to unexpected behavior because as a user you create a factory and you will expect that this description will be test but it will be excluded by the filter.

I would suggest that you move the filtering to the TrainMojo because then NLPf will exclude the classes in the training process and not in the testing process. Additionally, you won't have a conflict between <excludes> and engine factories.

During writing I had the idea to name the configuration tag <excludedTrainers>.

schrieveslaach commented on issue DisplayLink/evdi#133

@schrieveslaach
schrieveslaach commented on issue DisplayLink/evdi#133 Oct 27, 2018

I can confirm that evdi is working with xorg-server 1.20.3.

schrieveslaach opened an issue in jwilder/docker-gen

@schrieveslaach
schrieveslaach opened an issue in jwilder/docker-gen Oct 26, 2018
Add “Set” Function #293

Sometimes it is required to have a set of something. For example, I want to get a list of unique networks. {{ range $network := set $containers Net…

schrieveslaach pushed to project branch master at schrieveslaach / NLPf

schrieveslaach (03f4b3a6) at 23 Oct 18:47

Add report mojo in order to generate a report for isolated tools re...

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

Could you add an acceptance test too?

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

Okay, may be this is fine for now. But add a TODO comment.

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

Have you tested this feature thoroughly? In the description I see <exclusions> and <exclude>. How does Maven know to resolve these configuration values? I expected <excludes> and <exclude>.

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

Remove.

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

Typo: For example, when you include OpenNLP and StanfordNLP, every available tool combination will be trained and evaluated in order to determine the best-performing NLP pipeline. However, if you do not want to train and evaluate the OpenNlpSegmenter, you can exclude it through the plugin configuration.

schrieveslaach commented on merge request !11 at schrieveslaach / NLPf

typo: ... all tools that are available through the Maven dependencies, therefore it is possible to exclude specific NLP tools.

schrieveslaach reopened an issue in testcontainers/testcontainers-java

@schrieveslaach
schrieveslaach reopened an issue in testcontainers/testcontainers-java Oct 10, 2018
Cannot Use testcontainers with Isolated Containers #712

I do have a docker setup, providing container isolation with a user namespace. Following configuration: /etc/docker/daemon.json { "userns-remap": "d…

7 comments

schrieveslaach closed an issue in testcontainers/testcontainers-java

@schrieveslaach
schrieveslaach closed an issue in testcontainers/testcontainers-java Oct 10, 2018
Cannot Use testcontainers with Isolated Containers #712

I do have a docker setup, providing container isolation with a user namespace. Following configuration: /etc/docker/daemon.json { "userns-remap": "d…

7 comments

schrieveslaach commented on issue testcontainers/testcontainers-java#712

@schrieveslaach
schrieveslaach commented on issue testcontainers/testcontainers-java#712 Oct 10, 2018

@kiview, if you have a new SNAPSHOT version, I can test it on my machine.

schrieveslaach commented on pull request softprops/shiplift#86

@schrieveslaach
schrieveslaach commented on pull request softprops/shiplift#86 Sep 27, 2018

@softprops, any ETA when you merge new features?

schrieveslaach closed an issue in nextcloud/appstore

@schrieveslaach
schrieveslaach closed an issue in nextcloud/appstore Sep 20, 2018
Cannot Upload Release From Gitlab CI #579

I want to release an APP on the app store and this APP has been build by Gitlab CI. However, when I use the web interface and provide the Download …

1 comment

schrieveslaach commented on issue nextcloud/appstore#579

@schrieveslaach
schrieveslaach commented on issue nextcloud/appstore#579 Sep 20, 2018

Nevermind, I made a configuration mistake

schrieveslaach opened an issue in nextcloud/appstore

@schrieveslaach
schrieveslaach opened an issue in nextcloud/appstore Sep 20, 2018
Cannot Upload Release From Gitlab CI #579

I want to release an APP on the app store and this APP has been build by Gitlab CI. However, when I use the web interface and provide the Download …

schrieveslaach commented on commit stfalcon-studio/FrescoImageViewer@75d1c900d4

schrieveslaach opened an issue in camunda/camunda-bpm-swagger

@schrieveslaach
schrieveslaach opened an issue in camunda/camunda-bpm-swagger Aug 15, 2018
`/task` and `/task/{id}` do not refer to `TaskDto` #51

The resources /task and /task/{id} should refer to TaskDto because the generate Java code has Object or no return type. Here is an example of the r…

schrieveslaach commented on merge request !9 at GNOME / gtksourceview

BTW, thanks for setting up Gitlab. This makes it so much easier to submit patches. 👍

schrieveslaach opened merge request #9: latex.lang: add support of minted pac...

This MR add support to highlight the minted environment and the mintinline command, cf. minted package

schrieveslaach pushed to project branch master at schrieveslaach / gtksourceview

schrieveslaach (866bd755) at 23 Jun 08:03

latex.lang: add support of minted package

schrieveslaach created project schrieveslaach / gtksourceview

schrieveslaach closed merge request #1: latex.lang: add support of minted pac...

This MR add support to highlight the minted environment and the mintinline command, c. f. minted package

schrieveslaach opened merge request #1: latex.lang: add support of minted pac...

This MR add support to highlight the minted environment and the mintinline command, c. f. minted package